Hi @sagold , Can you please look into the PR and let me know your comments. This enables to control the inclusion of type specific values in getData response

Hi Mani,

thank you for your PR! I am waiting for some spare time review your MR.

Cheers,
Sascha

Hi @sagold,

Could you please review the merge request at your earliest convenience? I'm currently waiting on this change to proceed further.

Thanks in advance!
Best,
Mani

Hi @sagold ,
Can you please review the merge request ?

Thanks,
Mani

Hi Mani,

FYI I will do so this week.

Cheers,
Sascha

Thanks @sagold , waiting for it 🙂 .

Overall I agree with this merge request. This feature is likely to changed in the future in favor of a more consistent configuration (between required, optional properties, valid and invalid default values and now our new option). But right now, I am happy that you addressed this missing requirement and happy to change the api to support this.

Please note:

• as mentioned above, we can do better with the naming of the option
• all tests must pass (yarn test). For some reason your branch fails for draft tests. Unfortunately this is not yet done for MR.
• With dynamic schemas there is potential for gaps of this option - we should keep an eye on this

Cheers.
Sascha

Hi Sascha,
I have found the issue and now tests are passing. Also renamed the option as useTypeDefaults . Can you please review and let me know if further changes are required.

Thanks,
Mani

Hi Mani,

thank you for the update! I merge and publish your PR. Tests are passing on my side. An update of the documentation is missing, but I will add it myself to not further delay the PR.

Regards,
Sascha

Your changes have been published with v10.2.0. Also refer to the documentation here: https://github.com/sagold/json-schema-library?tab=readme-ov-file#getdata. Possible that we might to extend this new option to objects and arrays at some point.